Fix encoding warnings with PEP 597 enabled#398
Merged
Secrus merged 2 commits intopython-poetry:mainfrom Feb 8, 2024
Merged
Conversation
46fef2a to
7396086
Compare
7396086 to
ae23f60
Compare
Member
|
The contrib is overall a good idea. |
Contributor
Author
|
@bswck I think the idea is that for every open statement we explicitly declare whether the encoding is "utf-8" or "locale", but I agree that /dev/null probably doesn't need an encoding. Do you think it is an issue that we are explicit even with this one? |
Secrus
approved these changes
Feb 8, 2024
Contributor
Author
|
Thanks @Secrus! |
Member
|
I noticed that there is still one open warning: I'm not sure if we even want UTF-8 Mode to affect it. In any case, I think we should decide between:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Encoding Warnings with PEP 597 warnings enabled and enables the warnings in CI. It goes along with python-poetry/poetry#8893 and python-poetry/poetry-core#685.